Hi,Ben
Besides Dmitry's comments,
On Wed, 2009-11-18 at 23:29 +0000, Ben Dooks wrote:
> +config TOUCHSCREEN_S3C2410
> + tristate "Samsung S3C2410 touchscreen input driver"
> + depends on ARCH_S3C2410 && INPUT && INPUT_TOUCHSCREEN
> + select SERIO
> + help
> + Say Y here if you have the s3c2410 touchscreen.
> +
> + If unsure, say N.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called s3c2410_ts.
S3C24XX_ADC should be added to the depends.
> +#include <linux/slab.h>
I think this is not really needed because kernel.h is included already.
> +
> + ts.clock = clk_get(dev, "adc");
> + if (IS_ERR(ts.clock)) {
> + dev_err(dev, "cannot get adc clock source\n");
> + return -ENOENT;
> + }
> +
> + clk_enable(ts.clock);
> + dev_dbg(dev, "got and enabled clocks\n");
Well, we take 2410_ts as s3c adc client, so these work has been done in
s3c_adc_probe function of arch/arm/plat-s3c24xx.c
This should be duplicated.
And "#include <linux/clk.h>" is not needed because we don't use these
APIs
> + err_clk:
> + clk_put(ts.clock);
> + return ret;
> +}
Above reason and also for those "goto err_clk;"
> );
> +
> + clk_disable(ts.clock);
> + clk_put(ts.clock);
Same as above
> +
> +#ifdef CONFIG_PM
> +static int s3c2410ts_suspend(struct platform_device *pdev, pm_message_t state)
> +{
> + writel(TSC_SLEEP, ts.io + S3C2410_ADCTSC);
> + disable_irq(ts.irq_tc);
Same as above
> +
> +static int s3c2410ts_resume(struct platform_device *pdev)
> +{
> + struct s3c2410_ts_mach_info *info = pdev->dev.platform_data;
> +
> + clk_enable(ts.clock);
Same as above
Cheers,
Shine
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
