Re: [PATCH 1/1] TWL4030 keypad: keypad lock / unlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 10, 2009 at 10:24:08AM +0200, Samu Onkalo wrote:
> Sysfs interface for disabling and enabling keypad HW and
> PM management functions added to twl4030 keypad driver.

Might be nice to have the longer explanation in your cover letter in the
patch description...

> Signed-off-by: Samu Onkalo <samu.p.onkalo@xxxxxxxxx>

Shouldn't this be done via the existing device wakeup API?  That also
presents a sysfs control (power/wakeup IIRC).  The driver calls
device_init_wakeup() to flag support for this at startup then checks
device_may_wakeup() when suspending and configures the hardware
appropriately.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux