On Thu, 22 Oct 2009 02:39:28 +0500 Constantin Baranov <const@xxxxxxxx> wrote: > On Wed, 21 Oct 2009 22:41:58 +0200 Daniel Mack <daniel@xxxxxxxx> wrote: > > On Thu, Oct 22, 2009 at 01:21:21AM +0500, Constantin Baranov wrote: > > > I wonder why do you integrate the input driver into the leds driver. They > > > should be separated. Or at least the complex driver should be moved to the > > > "X86 Platform Specific Device Drivers" and renamed to some like "PC Engines > > > ALIX Extras". I personally would prefer the separation way. > > > > I would as well, yes. And I was of course considerating this when I > > hacked these lines. However, the major part of the LED driver and what > > it currently shares with the button implementation is the BIOS detection > > code which is so ugly that I didn't want to duplicate it ;) That would, > > however, be the only option if you wanted to split the drivers up. Or > > do you have any better idea? > > We may introduce new ALIX2 extended platform (module in arch/x86/kernel). > In the init function it shall perform detection. The module shall export > the is_alix2() function which shall be called from init functions of drivers. > Also the cs5535_gpio driver could be reused for gpio access (the previous > patch for leds-alix2 is copy&paste from cs5535_gpio). Moreover, the cs5535_gpio driver itself could be reworked and ported to the gpiolib. This goes far from initial task (button support) indeed :) Constantin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
