Re: [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 20, 2009 at 14:46, Chris Verges wrote:
> Hi Mike and Michael,
>
>>+config INPUT_ADXL34X
>>+config INPUT_ADXL34X_I2C
>>+config INPUT_ADXL34X_SPI
>
> Should the INPUT_ADXL34X option be auto-selected when the _I2C or _SPI
> counterparts are selected?  Something like:
>
> config HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X
>        depends on HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X_I2C
>        bool "..."
>        depends on I2C
>        select HAVE_INPUT_ADXL34X
>
> config INPUT_ADXL34X_SPI
>        bool "..."
>        depends on SPI_MASTER
>        select HAVE_INPUT_ADXL34X
>
> The end user would only see the INPUT_ADXL34X_SPI and INPUT_ADXL34X_I2C
> options, with the common INPUT_ADXL34X option being automagically
> selected due to the reverse dependencies.

while it should work nicely if we only dealt with bools, dealing with
tristates (and thus allowing the driver to be a module) doesnt work
cleanly.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux