Hi Kyungmin,
On Tue, Oct 13, 2009 at 10:15 PM, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> On Tue, Oct 6, 2009 at 09:45, Kyungmin Park <kmpark@xxxxxxxxxxxxx> wrote:
>
>> +/**
>> + * haptic_classdev_register - register a new object of haptic_classdev class.
>> + * @dev: The device to register.
>> + * @haptic_cdev: the haptic_classdev structure for this device.
>> + */
>> +int haptic_classdev_register(struct device *parent,
>> + struct haptic_classdev *haptic_cdev)
>> +{
>> + int ret;
>> +
>> + haptic_cdev->dev = device_create(haptic_class, parent, 0,
>> + haptic_cdev, "%s", haptic_cdev->name);
>> + if (IS_ERR(haptic_cdev->dev))
>> + return PTR_ERR(haptic_cdev->dev);
>> +
>> + /* register the attributes */
>> + ret = class_create_file(haptic_class, &class_attr_enable);
>> + if (ret) {
>> + printk(KERN_ERR "%s: class_create_file(enable) failed\n",
>> + __func__);
>> + return ret;
>> + }
>
> As mentioned in an earlier mail, this needs some explanation. What are
> you doing here? Creating a device below a class, and then add a bunch
> of attributes to the class itself, instead of the device you created?
>
> All calls to class_create_file() need to go, we can not allow any new
> users of this broken interface. As mentioned, if you need
> subsystem-wide attributes you need to use a bus and not a class,
> classes are flat and can not handle such things properly.
>
> Thanks,
> Kay
>
Any plan of refreshing these patches?
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
