Re: [PATCH] hp_sdc_rtc: Fix test in hp_sdc_rtc_read_rt()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 16, 2009 at 06:12:39PM +0200, Roel Kluin wrote:
> If left unsigned the hp_sdc_rtc_read_i8042timer() return value will not
> be checked correctly.
> 

Applied, thank you Roel.

> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
> index 216a559..ea821b5 100644
> --- a/drivers/input/misc/hp_sdc_rtc.c
> +++ b/drivers/input/misc/hp_sdc_rtc.c
> @@ -209,7 +209,7 @@ static inline int hp_sdc_rtc_read_rt(struct timeval *res) {
>  
>  /* Read the i8042 fast handshake timer */
>  static inline int hp_sdc_rtc_read_fhs(struct timeval *res) {
> -	uint64_t raw;
> +	int64_t raw;
>  	unsigned int tenms;
>  
>  	raw = hp_sdc_rtc_read_i8042timer(HP_SDC_CMD_LOAD_FHS, 2);

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux