On Tue, Oct 13, 2009 at 01:08:18AM +0200, Henrik Rydberg wrote: > Andrew Morton wrote: > > On Tue, 13 Oct 2009 00:23:43 +0200 > > "Henrik Rydberg" <rydberg@xxxxxxxxxxx> wrote: > > > >> This patch makes bcm5974 report raw multi-touch (MT) data in the form > >> of ABS_MT events. The module parameter (nomt) may be used to turn off > >> the effect of this patch. > >> > > > > Why do we need a module parameter to disable the newly-added feature? > > All MT events bypass the input filtering and gets sent directly to the X driver. > Although it works as intended, without visible side effects, the stream of > events is rather large, and since the bypassing is completely new behavior, I > felt compelled to provide an option to turn it all off. Perhaps it is just me > being paranoid. > What is the expected rate of the events when user touches the pad with 2-3 fingers? Could you giove me estimate? > > > > IMO, your first patch ("input: bcm5974: retract efi-broken > > suspend_resume") is 2.6.32 material whereas this one is 2.6.33 > > material? > > > > This assumes that the two patches can be safely separated in this > > manner, which does appear to be the case. > > > > I was imagining both for 2.6.33; the efi booting is just beginning to work, and > since no distro is using it fully so far the problem currently only hits the > adventure-seekers anyways. I'd wait then - it works fine in non-efi mode and maybe by the time EFI is ready reset_resume will start working as well. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html