Trilok Soni wrote:
Adding Bill Gatliff.
Hi Kyungmin,
Most of the driver looks fine. I have only one generic comment, but
not for this driver:
- Someone should really work on getting PWM framework (may be the one
written by Bill Gatliff) into the kernel, because
if we don't do this and if new PWM controller provides it's own APIs
then we can't leverage the chips using them, like the
case here for ISA1000 and ISA1200. These chips are using the pwm
APIs exported by Samsung PWM controller, but it would
be painful to integrate other PWM controller if that has slightly
little different API due to its nature.
So, it would be better to get one generic PWM framework mainline in
the kernel.
I can repost for review, if you like.
The only objection I received last time, IIRC, was that I proffered it
as a "generic" API but only provided support for a couple of AT91
parts. I haven't had much time to add other support, so I haven't
pushed for inclusion.
I would be happy to coordinate the development/migration of support to
the API. I can still do the AT91 parts and probably PXA, maybe
OMAP3430/Beagleboard. But I would need others to help me with the rest.
b.g.
--
Bill Gatliff
bgat@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
