On Thu, Sep 24, 2009 at 10:53:22AM -0600, miguel.aguilar@xxxxxxxxxxxx wrote:
>
> +config KEYBOARD_DAVINCI
> + tristate "TI DaVinci Key Scan"
> + depends on ARCH_DAVINCI_DM365
> + help
> + Say Y to enable keypad module support for the TI DaVinci
> + platforms (DM365)
Missing period.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called davinci_keyscan.
> +
> +
> +static int __init davinci_ks_probe(struct platform_device *pdev)
> +{
> + struct davinci_ks *davinci_ks;
> + struct input_dev *key_dev;
> + struct resource *res, *mem;
> + struct device * dev = &pdev->dev;
> + struct davinci_ks_platform_data *pdata = pdev->dev.platform_data;
> + int ret, i;
> +
> + dev_info(dev, "DaVinci Key Scan Driver\n");
The boot is already quite noisy and input core will emit message when
device is registered so this one is not needed.
> +
> + davinci_ks = kzalloc(sizeof(struct davinci_ks) +
> + sizeof(unsigned short) * pdata->keymapsize, GFP_KERNEL);
> + if(!davinci_ks) {
> + dev_dbg(dev, "could not allocate memory for private data\n");
> + return -ENOMEM;
> + }
> +
> + if (!pdata->keymap) {
> + dev_dbg(dev, "no keymap from pdata\n");
You are leaking davinci_ks here. Maybe you should check pdata->keymap
first.
> + return -EINVAL;
> + }
> +
> + memcpy(davinci_ks->keymap, pdata->keymap,
> + sizeof(unsigned short) * pdata->keymapsize);
> +
> + key_dev = input_allocate_device();
> + if (!key_dev) {
> + dev_dbg(dev, "could not allocate input device\n");
> + ret = -ENOMEM;
> + goto fail1;
> + }
> +
> + platform_set_drvdata(pdev, davinci_ks);
> +
> + davinci_ks->input = key_dev;
> +
> + davinci_ks->irq = platform_get_irq(pdev, 0);
> + if (davinci_ks->irq < 0) {
> + dev_err(dev, "no key scan irq\n");
> + ret = davinci_ks->irq;
> + goto fail2;
> + }
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(dev, "no mem resource\n");
> + ret = -EINVAL;
> + goto fail2;
> + }
> +
> + davinci_ks->pbase = res->start;
> + davinci_ks->base_size = resource_size(res);
> +
> + mem = request_mem_region(davinci_ks->pbase, davinci_ks->base_size, pdev->name);
> + if (!mem) {
> + dev_err(dev, "key scan registers at %08x are not free\n",
> + davinci_ks->pbase);
> + ret = -EBUSY;
> + goto fail2;
> + }
> +
> + davinci_ks->base = ioremap(davinci_ks->pbase, davinci_ks->base_size);
> + if (!davinci_ks->base) {
> + dev_err(dev, "can't ioremap MEM resource.\n");
> + ret = -ENOMEM;
> + goto fail3;
> + }
> +
> + /* Enable auto repeat feature of Linux input subsystem */
> + if (pdata->rep)
> + __set_bit(EV_REP, key_dev->evbit);
> +
> + /* Setup input device */
> + __set_bit(EV_KEY, key_dev->evbit);
> +
> + /* Setup the platform data */
> + davinci_ks->pdata = pdata;
> +
> + for (i = 0; i < davinci_ks->pdata->keymapsize; i++)
> + __set_bit(davinci_ks->pdata->keymap[i], key_dev->keybit);
> +
> + key_dev->name = "davinci_keyscan";
> + key_dev->phys = "davinci_keyscan/input0";
> + key_dev->dev.parent = &pdev->dev;
> + key_dev->id.bustype = BUS_HOST;
> + key_dev->id.vendor = 0x0001;
> + key_dev->id.product = 0x0001;
> + key_dev->id.version = 0x0001;
> + key_dev->keycode = davinci_ks->keymap;
> + key_dev->keycodesize = sizeof(davinci_ks->keymap[0]);
> + key_dev->keycodemax = davinci_ks->pdata->keymapsize;
> +
> + ret = input_register_device(davinci_ks->input);
> + if (ret < 0) {
> + dev_err(dev, "unable to register DaVinci keyscan device\n");
> + goto fail4;
> + }
> +
> + ret = request_irq(davinci_ks->irq, davinci_ks_interrupt, IRQF_DISABLED,
> + "davinci_keyscan", davinci_ks);
> + if (ret < 0) {
> + dev_err(dev, "unable to register DaVinci keyscan Interrupt\n");
> + goto fail5;
> + }
FWIW you may request IRQ before registering the device - as soon as it
is alloctaed it can survive events going through it.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
