On 9/16/2009 3:00 PM, Dmitry Torokhov wrote:
> Hi Joonyoung,
>
> On Wed, Sep 16, 2009 at 02:45:02PM +0900, Joonyoung Shim wrote:
>> +
>> +static irqreturn_t mcs5000_ts_interrupt(int irq, void *dev_id)
>> +{
>> + struct mcs5000_ts_data *data = dev_id;
>> + struct i2c_client *client = data->client;
>> + u8 buffer[READ_BLOCK_SIZE];
>> + int err;
>> + int x;
>> + int y;
>> +
>> + disable_irq_nosync(irq);
>> +
>
> I don't think we need to disable IRQ in the threaded handler - it should
> be masked off until we return...
>
Yor're right. It is unnecessary.
>> +
>> +static irqreturn_t mcs5000_ts_hardirq(int irq, void *dev_id)
>> +{
>> + return IRQ_WAKE_THREAD;
>> +}
>
> This is not needed, just pass NULL to request_threaded_irq().
>
OK, this is unnecessary too.
I will resend the patch after fix.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
