On Tue, Sep 15, 2009 at 23:45, Dmitry Torokhov wrote: > On Tue, Sep 15, 2009 at 10:00:40PM -0400, Mike Frysinger wrote: >> + >> +static int __devexit opencores_kbd_remove(struct platform_device *pdev) >> +{ >> + struct opencores_kbd *opencores_kbd = platform_get_drvdata(pdev); >> + >> + free_irq(opencores_kbd->irq, opencores_kbd); >> + >> + input_unregister_device(opencores_kbd->input); >> + kfree(opencores_kbd); > > You need to do iounmap and free the memory region here as well. ugh, i remembered i would have to do this while writing the initial code, but forgot while double checking the different error paths -mike -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html