On Wed, Sep 09, 2009 at 08:11:03PM +0900, jsgood.yang@xxxxxxxxxxx wrote:
> +#ifdef CONFIG_PM
> +static int s3c_keypad_suspend(struct platform_device *dev, pm_message_t state)
> +{
> + struct s3c_keypad *keypad = platform_get_drvdata(pdev);
> +
> + keypad->keyifcon = readl(keypad->regs + S3C_KEYIFCON);
> + keypad->keyiffc = readl(keypad->regs + S3C_KEYIFFC);
> +
> + disable_irq(IRQ_KEYPAD);
> + clk_disable(keypad->clk);
> +
> + return 0;
> +}
This will unconditionally enable the clock but the clock is only enabled
while the input device is opened. This may create confusion or generate
warnings with the clock API so it'd be better to avoid doing this.
A similar problem exists in the resume function.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
