On Wed, Sep 9, 2009 at 03:15, Song, Barry wrote: >From: Mike Frysinger [mailto:vapier.adi@xxxxxxxxx] >>On Tue, Sep 8, 2009 at 23:33, Song, Barry wrote: >>> +static inline int ad714x_spi_register_driver(struct >>> spi_driver *spi_drv) >>> +{ >>> + return spi_register_driver(spi_drv); >>> +} >>> + >>> +static inline void ad714x_spi_unregister_driver(struct >>spi_driver *spi_drv) >>> +{ >>> + spi_unregister_driver(spi_drv); >>> +} >>> + >>> +#else >>> +#define ad714x_spi_register_driver(p) 0 >>> +#define ad714x_spi_unregister_driver(p) >>> #endif >> >>i dont think you need the ifdef protection that far up. what about >>using the ifdef in this one place: >>static inline int ad714x_spi_register_driver(struct spi_driver >>*spi_drv) >>{ >>#if defined(CONFIG_SPI) || defined(CONFIG_SPI_MODULE) >> return spi_register_driver(spi_drv); >>#else >> return 0; >>#endif >>} >> >>then i imagine you can have all the other pieces always enabled. gcc >>will see that everything is marked static and not used, so it'll cull >>things. > > In fact, I have tried to do like this before changing like I sent in the last mail. In fact, it will get compiling error if I always enable all spi and i2c functions without a #ifdef protection. > So since there are far #ifdef, I think it shoud be better to place related codes to existed #ifdef. i really have no idea what you're trying to say or why it didnt work for you -mike -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
