Hi Kyungmin, On Mon, Sep 07, 2009 at 05:32:08PM +0900, Kyungmin Park wrote: > > They will merge your patches if you send them! They will learn as much from > > you, as they are from me when I provide feedback. > > It's already sent by Joonyoung, Do you mean the patch for your full driver code, or actually patches that modify the System LSI driver? System LSI will merge patches you send which they can apply to their code. If you just simply send your driver (which conflicts with their driver), this will not work. Your patches will have to come incremental to their work, so System LSI can apply them to their tree. > > So rather than continue to try to compete with each other, you need to work > > together. If you think your code is superior, why not submit your code as > > patches to System LSI, or even ask System LSI if you can either > > It's because we don't get same base code. LSI works on s3c6410, but we > s3c6410, s5pc100 and s5pc110. System LSI also works on s5pc100 and s5pc110, as I assume you know. They work on code for all of their SoCs ;) It is simply that the way their workflow is now structured with regard to mainline that they will first send patches to complete the 6410 support, and then move to 6440, c100 and last c110 > we trying to post the patches related with s3c6410 but it takes long > time to merge to Ben's git. Well, I think this is something you have to discuss with Ben. But anyone who works with mainline has to send incremental changes. So if you submit a keypad driver that contains code for a SoC that is not in mainline yet, it will not get accepted. You need to get the order right. This is independent who does the work, LSI or DMC, or anyone else. > Anyway. please let me know which the next patch. touchscreen? or others? > Than we can compare the devices sources and discuss internally and then post it. I will follow-up in a different mail, as this is becoming way too off-topic for linux-input. > > It is not "they" vs. "you" vs. "us", it is all of us together. There is too > > much work to be done. There is 6400,6410,6440,6430,6442,c100,c110 and more > > products lining up in the future. Many drivers spanning various subsystems. > > Only if the resources are put together this task can be finished in any > > reasonable amount of time. > > That's reason to send our codes. Now you focus on the s3c6410 but we > already know the s5pc1xx series. My focus is on aligning System LSI division's development for _all_ SoC's. As indicated before, they now no longer work on fixed kernel versions, but they always pull/merge from torvalds/linux-2.6 to make sure their code is much closer to mainline. > > System LSI is pushing their code for mainline, one patch at a time, like > > we are seeing with this keypad driver right now. This will generate feedback > > by the community (including you). System LSI then incorporates that feedback > > and re-submit an updated version of the driver - just like any other person > > who submits code to Linux mainline. > > I think no problem to send several patch or drivers parallel. If so we > can get more feedbacks. I disagree. Two departments of Samsung writing two drivers and then submitting them to the mailinglists 1) makes everyone, esp. the maintainer have to review two drivers 2) confuses the maintainer, as he does not know which one to apply Anyway, I think we should continue this discussion off-list and see how we can structure the workflow in a better way. -- - Harald Welte <laforge@xxxxxxxxxxxx> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
