On Sat, Sep 05, 2009 at 10:54:44PM +0900, 양진성 wrote: > This patch supports to select configuration for s3c matrix keypad. > Signed-off-by: Jinsung Yang <jsgood.yang@xxxxxxxxxxx> > Signed-off-by: Kyeongil Kim <ki0351.kim@xxxxxxxxxxx> A relatively technical point but you should always try to order your patch series so that the kernel always builds, even with the patch series partly applied. This means that if you've split out the build system changes that should be the last patch in the series. Doing this is useful when people use tools such as 'git bisect' which walk through history and also means that it's possible to do things like partially apply the series (for example, if you get a situation where the earlier patches are all OK but there's some issues that need to be resolved in the later ones). It'd probably also help to combine more of your changes together - in general it's better if patches achieve some goal in a self-contained fashion. This normally makes things easier to review. Things like doing the build system separately are normally there in order to split a very large driver into managable chunks. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
