On Mon, Aug 31, 2009 at 23:55, Barry Song<21cnbao@xxxxxxxxx> wrote: > --- /dev/null > +++ b/include/linux/spi/ad714x.h > @@ -0,0 +1,60 @@ > +/* > + * include/linux/ad714x.h > + * > + * AD714x is very flexible, it can be used as buttons, scrollwheel, > + * slider, touchpad at the same time. That depends on the boards. > + * The platform_data for the device's "struct device" holds this > + * information. > + */ missing lines: * Copyright 2009 Analog Devices Inc. * * Licensed under the GPL-2 or later. > +#ifndef AD714X_HW_H > +#define AD714X_HW_H header files should not be using an unprefixed name space (even if it's an uncommon define name), and the name really should match the header. i.e. __LINUX_SPI_AD714X_H__ -mike -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html