On Wed, Aug 12, 2009 at 05:05:28PM +0200, Sascha Hauer wrote: > This driver provides support for the touchscreen interface > integrated into the Freescale MC13783. > > changes since v1: > > - remove unused functions > - use queue_delayed_work instead of queue_work > - report pen events as BTN_TOUCH instead of ABS_PRESSURE > - handle interrupt registration in open/close functions > - do not call input_free_device() on already registered > input_device > - use platform_driver_probe instead of platform_driver_register BTW, if you are using platform_driver_probe() then __init is OK for .probe() because all probes will only be run once, when driver loads. IIRC the ability to discard probe() code was the main reason for introducing platform_driver_probe(). > + > + /* unmask the ts wakeup interrupt */ > + mc13783_set_bits(priv->mc13783, MC13783_REG_INTERRUPT_MASK_0, > + MC13783_INT_MASK_TSM, 0); > + > + mc13783_adc_set_ts_status(priv->mc13783, 1); > + I actually expected these bits to go into ->open(); not the request IRQ stuff... -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
