Re: [PATCH] input: make matrix keymap size dynamic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Torokhov wrote:
> Hi Eric,
> 
> On Tue, Aug 04, 2009 at 05:24:01PM +0800, Eric Miao wrote:
>> The number of rows and columns should really belong to 'struct keymap_data',
>> and assumption on the shift and size of rows/columns removed.
>>
> 
> I aplayed with your patch for a while and moving rows and columns into
> struct keymap_data did not feel right; the changes to activate_cols and
> others where we have to access 2 different structures to get gpios and
> upper limit made the code awkward. In the end I decided the sizes should
> be kept where they were, together with the gpio arrays.
> 
> What do you think about the modified version of your patch below? The
> definitions seem to be working for other matrix drivers I have i my
> queue as well...
> 

Sure go. I'm quite happy with your approach.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux