Hi Syed, On Wed, Jul 22, 2009 at 7:20 PM, Syed Rafiuddin<rafiuddin.syed@xxxxxx> wrote: > This patch adds OMAP4 support to the Keypad driver. This patch adds > OMAP4 register addresses and configures registers for OMAP4. > > Signed-off-by: Syed Rafiuddin <rafiuddin.syed@xxxxxx> >From the first look of this driver, I think omap-keypad driver is reaching its limit. There are lot's of cpu_is_xxx lurking in this drivers. I like drivers those who use them at minimum. First step to do is that, please remove omap2 gpio based keypad logic to matrix_keypad.c, that will be omap-keypad.c bit clean, and then start merging omap4 keypad code. -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
