On Wednesday 08 July 2009 10:52:19 am Bjorn Helgaas wrote: > On Wednesday 01 July 2009 02:20:59 am David Härdeman wrote: > > On Wed, July 1, 2009 01:11, Bjorn Helgaas wrote: > > > The winbond driver does not use any ACPI-specific functionality, so > > > it might be simpler to write it as a PNP driver (which would depend > > > on PNPACPI, of course). > > > > As far as I could tell from a quick look at include/linux/pnp.h, a > > pnp_driver doesn't seem to have any .shutdown methods either, so I'm not > > sure how it would help? > > PNPACPI parses the device resources for you, so you could get rid > of the _CRS stuff in your driver. > > The only reason PNP and ACPI don't have .shutdown is because nobody > has needed it yet. If you need it (and it sounds like you do), I > think the cleanest thing would be to add it to PNP and turn your > driver into a PNP driver. Here are two sample patches to show you what I was suggesting. These apply on top of the two Winbond patches currently in -mm. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
