Re: [PATCH v2] input:Add clk api support for w90p910 touchscreen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 09, 2009 at 10:37:03AM +0300, Baruch Siach wrote:
> Hi Dmitry,
> 
> On Wed, Jul 08, 2009 at 11:29:29PM -0700, Dmitry Torokhov wrote:
> > On Thu, Jul 09, 2009 at 01:14:36PM +0800, Wan ZongShun wrote:
> > > Dmitry Torokhov 写道:
> > > > Hi Wan,
> > > > 
> > > > On Thu, Jul 09, 2009 at 10:53:18AM +0800, Wan ZongShun wrote:
> > > >> @@ -311,6 +309,9 @@ static int __devexit w90x900ts_remove(struct platform_device *pdev)
> > > >>  	del_timer_sync(&w90p910_ts->timer);
> > > >>  	iounmap(w90p910_ts->ts_reg);
> > > >>  
> > > >> +	clk_disable(w90p910_ts->clk);
> > > > 
> > > > This disable is unneeded since we already disable clock in close(). I
> > > > will fix locally and apply, there is no need to resubmit. I will also
> > > > fix pxa27 driver.
> > > 
> > > Okay, got it, thanks for your help!
> > > 
> > 
> > Umm, one more thing - we need to add "depends on" to Kconfig since
> > clk API is not implemented on every platform. Any ideas what is the
> > most wide dependency is?
> 
> The most wide dependency for the clk API is HAVE_CLK.
> 

Cool, thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux