Hi Dmitry, On Mon, Jun 29, 2009 at 9:56 PM, Dmitry Torokhov<dmitry.torokhov@xxxxxxxxx> wrote: > Hi Eric, > > On Fri, Jun 12, 2009 at 09:26:43PM +0800, Eric Miao wrote: >> >> Hi Dmitry, >> >> I've tested the driver code, and it's basically OK except for two minor >> fixes: >> >> 1) GPIO and IRQs have to be initialized before input_register_device(), >> otherwise input->open() will be invoked before that, which will schedule >> an immediate scan work and fail. >> >> 2) disable_irq_rows() called in init_matrix_gpio() so that by default it's >> initialized to disabled - and will be enabled by input->open() >> > > Could you please take a look at the driver as it is commited to > 'for-linus' branch of my tree and let me know if you see anything wrong > there? Otherwise I inted to submit it in my next update to Linus. > Are you planning to take "MAX7359 input switch controller driver" too for submission to Linus in -rc1? -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
