Em Dom, 2009-06-28 às 12:49 +0530, Trilok Soni escreveu:
> > + pcap_keys->input->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_SW);
> > + set_bit(KEY_POWER, pcap_keys->input->keybit);
> > + set_bit(SW_HEADPHONE_INSERT, pcap_keys->input->swbit);
> > + set_bit(KEY_HP, pcap_keys->input->keybit);
>
> __set_bit please.
Ok.
> > +
> > + err = request_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_ONOFF),
> > + pcap_keys_handler, 0, "Power key", pcap_keys);
> > + if (err)
> > + goto fail_dev;
> > +
> > + err = request_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_HS),
> > + pcap_keys_handler, 0, "Headphone jack", pcap_keys);
> > + if (err)
> > + goto fail_pwrkey;
> > +
> > + err = request_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_MIC),
> > + pcap_keys_handler, 0, "MIC jack/button", pcap_keys);
> > + if (err)
> > + goto fail_jack;
> > +
> > + err = input_register_device(pcap_keys->input);
> > + if (err)
> > + goto fail_mic;
>
> Same comment as given in PCAP touchscreen driver.
Ok.
> > +static struct platform_driver pcap_keys_device_driver = {
> > + .probe = pcap_keys_probe,
> > + .remove = pcap_keys_remove,
>
> __devexit_p ?
Ok.
Thanks for the review, I will send new versions addressing your comments
as soon as possible.
--
Daniel Ribeiro
Attachment:
signature.asc
Description: Esta =?ISO-8859-1?Q?=E9?= uma parte de mensagem assinada digitalmente
