On Wed, 17 Jun 2009, Rafi Rubin wrote:
> When both touch and pen are active send a tool announcement before
> sending any status changes so that event users may differentiate
> which tool is changing.
>
> Restored three usage codes used by the pen.
>
> Signed-off-by: Rafi Rubin <rafi@xxxxxxxxxxxxxx>
> ---
> drivers/hid/hid-ntrig.c | 31 ++++++++++++++++++++++++++++---
> 1 files changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
> index 75ed9d2..7765970 100644
> --- a/drivers/hid/hid-ntrig.c
> +++ b/drivers/hid/hid-ntrig.c
> @@ -27,6 +27,9 @@
> struct ntrig_data {
> __s32 x, y, id, w, h;
> char reading_a_point, found_contact_id;
> + char pen_active;
> + char finger_active;
> + char inverted;
> };
>
> /*
> @@ -63,10 +66,7 @@ static int ntrig_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> case HID_UP_DIGITIZER:
> switch (usage->hid) {
> /* we do not want to map these for now */
> - case HID_DG_INVERT: /* value is always 0 */
> - case HID_DG_ERASER: /* value is always 0 */
> case HID_DG_CONTACTID: /* value is useless */
> - case HID_DG_BARRELSWITCH: /* doubtful */
> case HID_DG_INPUTMODE:
> case HID_DG_DEVICEINDEX:
> case HID_DG_CONTACTCOUNT:
> @@ -125,6 +125,18 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
>
> if (hid->claimed & HID_CLAIMED_INPUT) {
> switch (usage->hid) {
> +
> + case HID_DG_INRANGE:
> + if(field->application & 0x3)
> + nd->pen_active = value!=0;
> + else
> + nd->finger_active = value!=0;
Maybe putting brackets around the comparsion and putting spaces around
'!=' would make the code more readable and easy to understand on a first
sight?
> + return 0;
> +
> + case HID_DG_INVERT:
> + nd->inverted = value;
> + return 0;
> +
> case HID_GD_X:
> nd->x = value;
> nd->reading_a_point = 1;
> @@ -148,6 +160,10 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
> * to emit a normal (X, Y) position
> */
> if (! nd->found_contact_id) {
While at it, could you please remove the space after '!' to be compatible
with the kernel coding style?
> + if(nd->pen_active && nd->finger_active) {
And insert a space after 'if' here.
> + input_report_key(input, BTN_TOOL_DOUBLETAP, 0);
> + input_report_key(input, BTN_TOOL_DOUBLETAP, 1);
> + }
> input_event(input, EV_ABS, ABS_X, nd->x);
> input_event(input, EV_ABS, ABS_Y, nd->y);
> }
> @@ -159,6 +175,14 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
> * to emit a normal (X, Y) position
> */
> if (! nd->found_contact_id) {
> + if(nd->pen_active && nd->finger_active) {
And the same here.
Stéphane, did you have chance to verify with your device, that everything
works as expected with this version of Rafi's patch?
Thanks,
--
Jiri Kosina
SUSE Labs
