Le 19 mai 09 à 16:50, Jiri Kosina a écrit :
+ static __s32 x, y, id, w, h;
+ static char reading_a_point = 0, found_contact_id = 0;
+ struct input_dev *input = field->hidinput->input;
Why are these variables static? This will break horribly if multiple
devices are connected to the system, right?
You're right. But so far these devices are sold only as embedded in a
notebook, and I doubt we will see standalone devices in the near
future. Do you think it is worth planning ahead for this eventuality?
Please use kernel-style comments (i.e. stars on each line).
Will do.
+ case 0xff000000:
+ /* we do not want to map these */
Why?
Will add a couple of words.
+ default:
+ hidinput_hid_event(hid, field, usage, value);
Just return 1; here?
+ }
+ }
+ if (hid->claimed & HID_CLAIMED_HIDDEV && hid-
>hiddev_hid_event)
+ hid->hiddev_hid_event(hid, field, usage, value);
+
+ return 1;
And return 0; here and let the HID core do all the rest (passing to
hidinput and hiddev, etc) if necessary?
See my question in my other reply.
Cheers,
St.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
