Re: [PATCH] input: add driver for EETI touchpanels [v4]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

thanks for your input.

On Sat, May 16, 2009 at 05:57:16PM +0200, Jean Delvare wrote:
> > +	struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> > +	struct eeti_ts_priv *priv;
> > +	struct input_dev *input;
> > +	int err = -ENOMEM;
> > +
> > +	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
> 
> This functionality does not correspond to the I2C access method your
> code uses. You must check for I2C_FUNC_I2C instead (if you want to
> check at all - it's essentially optional with the new binding model.)

Yes, I though so too and removed the check for now.
New version coming up.

Thanks,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux