[PATCH] Input: tsc2007: Remove a useless code and check a necessary function is provided or not

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

This patch contains a trivial removal and check the existence of a
platform specific function.

Regards,
Kwangwoo Lee

>From bc18ba8c71027ca58d1242149eee9919bdaa069b Mon Sep 17 00:00:00 2001
From: Kwangwoo Lee <kwangwoo.lee@xxxxxxxxx>
Date: Fri, 15 May 2009 13:43:55 +0900
Subject: [PATCH] Input: tsc2007: remove useless code and check a
necessary function is provided or not.

Remove a useless code and check a necessary function is implemented or not.
The platform codes must provide get_pendown_state() to work properly.

Signed-off-by: Kwangwoo Lee <kwangwoo.lee@xxxxxxxxx>
---
 drivers/input/touchscreen/tsc2007.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007.c
b/drivers/input/touchscreen/tsc2007.c
index 948e167..da35adb 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -253,11 +253,11 @@ static int tsc2007_probe(struct i2c_client *client,
 			const struct i2c_device_id *id)
 {
 	struct tsc2007 *ts;
-	struct tsc2007_platform_data *pdata = pdata = client->dev.platform_data;
+	struct tsc2007_platform_data *pdata = client->dev.platform_data;
 	struct input_dev *input_dev;
 	int err;

-	if (!pdata) {
+	if (!pdata || !pdata->get_pendown_state) {
 		dev_err(&client->dev, "platform data is required!\n");
 		return -EINVAL;
 	}
-- 
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux