On Tue, May 12, 2009 at 01:43:06PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > From: Harvey Harrison <harvey.harrison@xxxxxxxxx> > > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx> > Cc: Dmitry Torokhov <dtor@xxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > drivers/input/touchscreen/ads7846.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff -puN drivers/input/touchscreen/ads7846.c~input-ads7846c-sparse-lock-annotation drivers/input/touchscreen/ads7846.c > --- a/drivers/input/touchscreen/ads7846.c~input-ads7846c-sparse-lock-annotation > +++ a/drivers/input/touchscreen/ads7846.c > @@ -769,6 +769,8 @@ static irqreturn_t ads7846_irq(int irq, > > /* Must be called with ts->lock held */ > static void ads7846_disable(struct ads7846 *ts) > +__releases(&ts->lock) > +__acquires(&ts->lock) > { I still haven't gotten any explanation why this is needed and also I am still getting sparce warnings with this patch applied. Please drop. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html