On Mon, May 11, 2009 at 05:48:55PM +0200, Jiri Slaby wrote: > Here comes some of my comments to the rest: > > +#define debug(format, arg...) pr_debug("hid-sjoyff: " format "\n" , ## arg) > > Define pr_fmt instead of this. No, please use dev_dbg() instead of creating a new macro. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html