On Mon, 11 May 2009, Jiri Slaby wrote: > Strictly speaking, it depends on whether the device is able to be > managed by the generic layer or not. And it seems it can; this driver > adds only a FF support. If we disabled the FF support in the config and > the #if macro wasn't there, we would lose the device completely even > though it can be handled by the core, without FF though. That was exactly my point, yes. > So I think, in this particular case, it is OK to have the conditional > line in there. Actually this should be the case at least for - all drivers which implement only force feedback features - all drivers which only add additional key mappings -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html