On Fri, 8 May 2009, ?????? ??????? wrote: > > I am ready to create autocenter support patch for Logitech Force 3D > > Pro (046d:c286). But all tested by me Logitech Joysticks with FF has > > support for autocentering in same way. May be it is good idea to add > > this feature for all joysticks in hid-lgff.c? If some joystick do not > > support it (users reported), then it is possible to exclude > > autocentering for this joystick later. The standard doesn't mandate anything, as far as I know. Also, we know how creative HID vendors are when braking all kinds of specifications/reasonable expectations. So I'd propose to go with enabling the feature only for those joysticks for which it is verified to work. Therefore, I would propose merging your patch no. 1, if you agree. Thanks, -- Jiri Kosina SUSE Labs