Hi KIm, On Sunday 10 May 2009 18:51:32 Kim Kyuwon wrote: > Hi Dmitry, > > Thank you for streamlining this driver. I confirmed this streamlined driver > is nicely working on my S3C6410 board and of course I mostly like your > changes. Great, thanks for testing. > But I'm afraid this 'error' variable is not used at the final > return statement in the probe function. *blush* Hm, apparently I did not quite finish converting it all to use "error" ;) I personally like calling such variables "error" if they are "returned" only in error path and "ret" or "retval" when they are returned upon both error and successful completion of a function. I will fold your patch into the original version, thanks a lot. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
