Hi Daniel,
On Thu, May 07, 2009 at 07:35:02PM +0200, Daniel Mack wrote:
> > +
> > + if (buf[0] & REPORT_BIT_HAS_PRESSURE)
> > + input_report_abs(priv->input, ABS_PRESSURE, buf[5]);
> > +
> > + input_report_key(priv->input, BTN_TOUCH, !!pressed);
> > + input_report_abs(priv->input, ABS_X, x);
> > + input_report_abs(priv->input, ABS_Y, y);
> > + input_sync(priv->input);
I think you should also do:
if (!pressed)
input_report_abs(priv->input, ABS_PRESSURE, 0);
for the benefit of applications that use purely pressure data to
determine touch points.
> > + enable_irq(priv->irq);
> > +}
> > +
> > +static irqreturn_t eeti_ts_isr(int irq, void *dev_id)
> > +{
> > + struct eeti_ts_priv *priv = dev_id;
> > +
> > + /* postpone I2C transactions as we are atomic */
> > + disable_irq_nosync(irq);
> > + schedule_delayed_work(&priv->work, HZ / 100);
> > +
> > + return IRQ_HANDLED;
> > +}
> > +
> > +static int eeti_ts_open(struct input_dev *dev)
> > +{
> > + struct eeti_ts_priv *priv = input_get_drvdata(dev);
Blank line after declarations, pretty please. Also, is it mailer's fault
or you need to use tabs for identation.
> > + /* Read the events once to arm the IRQ */
> > + eeti_ts_read(&priv->work.work);
> > +
> > + return 0;
> > +}
> > +
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
