Hi,
> +#if 0
> +static int mxc_keypad_open(struct input_dev *dev)
> +{
> + struct mxc_keypad *kp = input_get_drvdata(dev);
> + struct clk *clk;
> +
> + /* Enable unit clock */
> + clk = clk_get(&pdev->dev, "kpp");
> + if (IS_ERR(clk))
> + return -ENODEV;
>
Why do you invent your own error code instead of reporting the error
that clk_get() returned?
> + clk = clk_get(&dev->dev, "kpp");
> + if (clk)
>
'if (!IS_ERR(clk))' please!
> + clk = clk_get(&pdev->dev, "kpp");
> + if (IS_ERR(clk)) {
> + error = -ENODEV;
See above.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@xxxxxxxxxxxxxxxxxxx
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
