In a recent patch [1], Daniel Ritz added USB_DEVICE_ID_MATCH_INT_PROTOCOL for the "match_flags" of the USB_DEVICE_HID_CLASS macro, but I have another "eGalax" controller with the same USB properties but that needs to be handled by the usbhid driver. My "/proc/bus/usb/devices" part: T: Bus=05 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=1.5 MxCh= 0 D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs= 1 P: Vendor=0eef ProdID=0001 Rev= 1.00 S: Manufacturer=eGalax Inc. S: Product=Touch C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr= 44mA I:* If#= 0 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid E: Ad=81(I) Atr=03(Int.) MxPS= 8 Ivl=10ms If I remove the USB_DEVICE_ID_MATCH_INT_PROTOCOL then the usbtouchscreen driver ignores the device and usbhid takes over as it should be. But with the current code, usbtouchscreen claims the device and as it doesn't understand the protocol makes the device unusable. The device mentioned on the thread that needs the usbtouchscreen driver was this: T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 13 Spd=1.5 MxCh= 0 D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs= 1 P: Vendor=0eef ProdID=0001 Rev= 1.00 C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr= 44mA I:* If#= 0 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid E: Ad=81(I) Atr=03(Int.) MxPS= 8 Ivl=5ms It seems the eGalax USB ID (0eef:0001) is being (ab)used by a lot of different manufacturers, but shouldn't the default be to let the usbhid driver to decide if it can or not use the device if the device class is HID? All other "eGalax" devices I have seen that really need the usbtouchscreen driver have the 0xff class, like the one below: T: Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=1.5 MxCh= 0 D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs= 1 P: Vendor=0eef ProdID=0001 Rev= 1.00 S: Manufacturer=eGalax Inc. S: Product=USB TouchController C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=100mA I:* If#= 0 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=usbtouchscreen E: Ad=81(I) Atr=03(Int.) MxPS= 8 Ivl=5ms If there are devices that need to use usbtouchscreen and have the HID class then, in my view, are plain broken. Maybe the solution would be to somehow allow the user to re-attach the device to a different driver. As I'm no kernel programmer, anyone care to comment? Regards, ~Nuno Lucas [1] http://lkml.org/lkml/2009/2/8/70 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
