Re: [PATCH] input: add suspend wakeup support to sh_keysc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Magnus,

>>
>> Please add device_init_wakeup(&pdev->dev, 0) in sh_keysc_remove.
>
> Isn't this just flagging the device as wakeup capable? My first guess
> would be that the the wakeup state of a removed device is irrelevant
> since it won't be suspended anyway. Or am I misunderstanding? Please
> explain in more detail.

I may not have complete answer, but I am thinking of someone depending/reading
on wakeup file state to determine the state of your device in userspace will get
confused, so better to disable to wakeup capability on remove.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux