On Mon, Mar 2, 2009 at 23:42, Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote: > --- /dev/null > +++ b/drivers/char/idle.c > @@ -0,0 +1,445 @@ > +#ifdef DEBUG > +#define idle_printk(args...) printk(KERN_DEBUG "IDLEDEV: " args) > +#else > +#define idle_printk(args...) do {} while (0) > +#endif Please use the standard debug interface, i.e. #define pr_fmt(fmt) "IDLEDEV: " fmt and use pr_debug() everywhere, to always have printf()-style format checking. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html