Hi, On Thu, Feb 26, 2009 at 4:01 PM, Trilok Soni <soni.trilok@xxxxxxxxx> wrote: > Hi Kyungmin, > >> diff --git a/drivers/input/input.c b/drivers/input/input.c >> index 1730d73..7e96635 100644 >> --- a/drivers/input/input.c >> +++ b/drivers/input/input.c >> @@ -274,6 +274,8 @@ void input_event(struct input_dev *dev, >> add_input_randomness(type, code, value); >> input_handle_event(dev, type, code, value); >> spin_unlock_irqrestore(&dev->event_lock, flags); >> + if (type == EV_KEY) >> + input_notifier_call_chain(value, &code); > > This check will be done for every input_report_xxx calls, even for > touchscreen events (in which case of course it will fail), and I don't > think this is optimal solution. Users should be given an option to > disable this if they don't need this notification mechanism. > > How about moving this to input_report_key? Good, Thank you for point it. I will move it to input_report_key. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
