>From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] >Sent: Thursday, February 05, 2009 11:01 PM >Subject: Re: [PATCH] Input: bf54x-keys: ! has a higher priority than > > >On Thu, 5 Feb 2009 15:19:55 +0800 >Bryan Wu <cooloney@xxxxxxxxxx> wrote: > >> From: Roel Kluin <roel.kluin@xxxxxxxxx> >> >> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> >> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> >> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx> >> --- >> drivers/input/keyboard/bf54x-keys.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/keyboard/bf54x-keys.c >b/drivers/input/keyboard/bf54x-keys.c >> index 1928401..ee855c5 100644 >> --- a/drivers/input/keyboard/bf54x-keys.c >> +++ b/drivers/input/keyboard/bf54x-keys.c >> @@ -209,8 +209,8 @@ static int __devinit bfin_kpad_probe(struct >platform_device *pdev) >> goto out; >> } >> >> - if (!pdata->debounce_time || !pdata->debounce_time > MAX_MULT || >> - !pdata->coldrive_time || !pdata->coldrive_time > MAX_MULT) { >> + if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT || >> + !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) { > >What is this `pdata' thing from which the data comes? Platform device data. struct bfin_kpad_platform_data *pdata = pdev->dev.platform_data; > >It seems a bit rude to kill the driver when we've detected an error >which could easily be fixed up. It actually just prints the error and then uses some default value later on. > >> printk(KERN_ERR DRV_NAME >> ": Invalid Debounce/Columdrive Time from pdata\n"); > >nit: a colon does not terminate a sentence. > >This comment misspells "column". Bryan will send a patch addressing this typo. Best regards, Michael -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
