On Sat, 24 Jan 2009, Jaswinder Singh Rajput wrote: > This leads to 3 headers_check warnings: > > usr/include/linux/hid.h:66: leaks CONFIG_HID to userspace where it is not valid > usr/include/linux/hid.h:69: extern's make no sense in userspace > usr/include/linux/hid.h:76: extern's make no sense in userspace > > So I am moving whole above block in #ifdef __KEREL__ > > If you have any objections, then let me know, now it will look like this: > > #endif /* HID_FF */ > > +#ifdef __KERNEL__ > #ifdef CONFIG_HID_COMPAT > #define HID_COMPAT_LOAD_DRIVER(name) \ > /* prototype to avoid sparse warning */ \ > @@ -804,6 +805,7 @@ EXPORT_SYMBOL(hid_compat_##name) > extern void hid_compat_##name(void); \ > hid_compat_##name(); \ > } while (0) > +#endif /* __KERNEL__ */ > > #endif Thanks for catching this. Could you please resend the patch to me, with proper changelog and Signed-off-by: line? Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
