On Fri, Jan 09, 2009 at 12:10:26PM +0000, Ben Dooks wrote:
> From: Vincent Sanders <vince@xxxxxxxxxxxx>
>
> Zytronic USB-attached capacitive touchscreen support
> within the generic USB touchscreen driver.
>
> Signed-off-by: Daniel Silverstone <dsilvers@xxxxxxxxxxxx>
> Signed-off-by: Vincent Sanders <vince@xxxxxxxxxxxx>
>
Since you are passing the driver on your sign off is also needed.
> Index: linux.git/drivers/input/touchscreen/usbtouchscreen.c
> ===================================================================
> --- linux.git.orig/drivers/input/touchscreen/usbtouchscreen.c 2009-01-08 15:26:04.000000000 +0000
> +++ linux.git/drivers/input/touchscreen/usbtouchscreen.c 2009-01-09 12:03:39.000000000 +0000
> @@ -13,6 +13,7 @@
> * - IdealTEK URTC1000
> * - General Touch
> * - GoTop Super_Q2/GogoPen/PenPower tablets
> + * - Zytronic capacitive touchscreen
> *
> * Copyright (C) 2004-2007 by Daniel Ritz <daniel.ritz@xxxxxx>
> * Copyright (C) by Todd E. Johnson (mtouchusb.c)
> @@ -68,6 +69,11 @@ struct usbtouch_device_info {
> int min_press, max_press;
> int rept_size;
>
> + /* Always service the USB devices irq not just when the input device is
> + * open.
> + */
> + int irq_always;
> +
Why is this needed?
> + case 0xC0: /* down */
> + dev->x = (pkt[1] & 0x7f) | ((pkt[2] & 0x07) << 7);
> + dev->y = (pkt[3] & 0x7f) | ((pkt[4] & 0x07) << 7);
> + dev->touch = 1;
> + dev->press = 1;
Since the device does not report real pressure readings don't try to
fake it, reporting touch is enough.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
