Re: Adding 'half shutter' definition to 'input.h'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, All
Because Jiri Kosina personally agrees with adding the [half]shutterkey yesterday,I'm sending this patch. (Thanks Jiri)
New cameras and mobile phones (at least SAMSUNG's) have the half shutter for'auto-focus' functions. so I think this half and full shutter keys are needed.
Please review this patch.Thank you!
On Wed, Dec 24, 2008 at 9:31 AM, 김규원 <chammoru@xxxxxxxxx> wrote:> Thanks for your reply ;)>> On Tue, Dec 23, 2008 at 5:45 PM, Dmitry Torokhov> <dmitry.torokhov@xxxxxxxxx> wrote:>> Hi Kim,>>>> On Monday 22 December 2008 22:27:51 Kyu-Won Kim wrote:>>> Hi Dmitry,>>>>>> We are making the camera application for mobile phone and our products have>>> half shutter (the technical name of buttion is "Double-action>>> Side-operation Type Light Touch Switch") as other general cameras.>>> Datasheet is here:>>> http://www.datasheetpro.com/205793_view_EVQQ0C03K_datasheet.html>>>>>> The problem is that there is no KEY definition for half shutter in input.h.>>> I think KEY_CAMERA is the most related key but we need more definitions>>> like KEY_CAMERA2, KEY_HALFSUTTER or KEY_FULLSHUTTER>>>>>> Could you give me your opinions about this half shutter>>>>>>> Hmm, we certainly could add some more key definitions, but given that the>> usage is very tightly coupled to the device and application I wonder if you>> should simply use KEY_PROG* there...>> We can simply use KEY_PROG1, but state-of-the-art digital camera supports> 'auto-focus' functions and therefore I think Half-Shutter key is a MUST. (I'm> sure there are many digital cameras which use Linux as OS).>>>>> Let's CC Jiri Kosina and see if he has any input on this matter.>> Can I ask Kosina's opinion, too?>>>>> -->> Dmitry>>>>> --> Kim Kyuwon>
commit a2f0629f9202433cd2b23b5c951dae66fd2b4f14Author: Kim Kyuwon <kyuwonmoru.kim@xxxxxxxxxxx>Date:   Thu Jan 8 11:08:43 2009 +0900
    Input: add definitions for camera full and half shutters    Signed-off-by: Kim Kyuwon <kyuwonmoru.kim@xxxxxxxxxxx>
diff --git a/include/linux/input.h b/include/linux/input.hindex 9a6355f..41ed2fb 100644--- a/include/linux/input.h+++ b/include/linux/input.h@@ -541,6 +541,9 @@ struct input_absinfo { #define KEY_CONTEXT_MENU	0x1b6	/* GenDesc - system context menu */ #define KEY_MEDIA_REPEAT	0x1b7	/* Consumer - transport control */
+#define KEY_HALF_SHUTTER	0x1b8+#define KEY_FULL_SHUTTER	0x1b9+ #define KEY_DEL_EOL		0x1c0 #define KEY_DEL_EOS		0x1c1 #define KEY_INS_LINE		0x1c2
-- Kim Kyuwonÿ淸º{.nÇ+돴윯돪†+%듚ÿ깁負¥Šwÿº{.nÇ+돴¥Š{깸)墉穡왲^n‡r⊆¦zË곷h솳鈺Ú&{àz요z받쀺+€Ê+zf"·hš닱~넮녬iÿÿï곴ÿ묎çz_溫æj:+v돣þ)山øm


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux