On Tuesday 30 December 2008 15:27:05 Adrian McMenamin wrote: > Adding maple mouse with proper __devexit_p() handling this kind of patch revision info typically goes below the --- marker and the patch itself gets "v2", "v3", etc... header markers otherwise, driver looks OK to me. thanks for your dreamcast work. Acked-by: Mike Frysinger <vapier@xxxxxxxxxx> > + mse = kzalloc(sizeof(struct dc_mouse), GFP_KERNEL); personally i find this style less likely to rot: mse = kzalloc(sizeof(*mse), GFP_KERNEL); -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.