Re: [patch 2.6.28-rc6-davinci1 5/6] dm355evm input driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 07 December 2008, Felipe Balbi wrote:
> > +     platform_set_drvdata(pdev, keys);
> > +     keys->pdev = pdev;
> 
> you could be holding only the device pointer.
> 
>         keys->dev = &pdev->dev;
> 
> then, if you really happen to need the pdev pointer you can use
> 
> to_platform_device(keys->dev);

True, that would be a bit simpler; the device handle is what's
normally needed, e.g. for dev_dbg().  I'd take an update patch;
but for now I'll avoid a re-test cycle.  :)

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux