Re: [patch] add module parameter to provide hardware-calibrated coordinate data for MicroTouch/3M touchscreens

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 24 Nov 2008, Dan Streetman wrote:

> This patch adds a module parameter to report either the raw coordinate data or 
> the hardware-calibrated coordinate data.  The default is set to the raw 
> coordinates for backwards compatibilty.

Please don't forget to include input subsystem maitainer (Dmitry Torokhov) 
when sending patches to code residing in drivers/input. Added.

> @@ -294,6 +303,12 @@ static int mtouch_init(struct usbtouch_u
>  			return ret;
>  	}
>  
> +	// Default min/max xy are the raw values, override if using hw-calib

Please use style of comments that is in compliance with kernel coding 
style.

Otherwise I think that the patch is fine.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux