Re: Lockdep violation in 2.6.28-rc4 + gregkh-all

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 Nov 2008, Alan Stern wrote:

> Here's what the lockdep trace indicates:
> 
> 	Somewhere in the input_register_device / input_attach_handler
> 	path, you lock input_dev->mutex.  While that lock is held,
> 	kbd_connect calls down to usbhid_open, which calls
> 	usb_autopm_get_interface, which acquires usb_dev->pm_mutex.
> 
> 	hid_suspend is called with usb_dev->pm_mutex held.  It
> 	acquires usbhid->setup.

Jiri, do we really need the ->setup mutex in fact? Aren't 
test_bit()/set_bit() for HID_STARTED and HID_SUSPENDED on the iofl 
sufficient to prevent races between start/resume and stop/suspend?

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux