On Thu, Nov 13, 2008 at 06:25:39PM -0500, Dan Streetman wrote: > > On Thu, Nov 13, 2008 at 3:31 PM, Greg KH <greg@xxxxxxxxx> wrote: > > On Thu, Nov 13, 2008 at 03:22:52PM -0500, Dan Streetman wrote: > >> > >> --- a/drivers/input/touchscreen/usbtouchscreen.c 2008-11-12 > >> 13:06:23.000000000 -0500 > >> +++ b/drivers/input/touchscreen/usbtouchscreen.c 2008-11-12 > >> 13:07:44.000000000 -0500 > > > > Your patch is line-wrapped :( > > Stupid gmail! :( > I'm trying now with thunderbird but I'm not sure if it has problems also or > not. I'm attaching the patch as well just in case :( Still linewrapped (the attached version isn't but then you have 2 copies of the same patch in one email, which our tools do not like...) > >> @@ -60,6 +60,10 @@ static int swap_xy; > >> module_param(swap_xy, bool, 0644); > >> MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped."); > >> > >> +static int hwcalib_xy = 0; > >> +module_param(hwcalib_xy, bool, 0444); > >> +MODULE_PARM_DESC(hwcalib_xy, "If set hw-calibrated X/Y are used if > available"); > > > > Should this variable be allowed to be changed at run time? That might > > be useful if the code is built into the system. If so, please change > > the permissions on the module_param() call. > > I set it as read only because I had to override the min/max coordinate > values in the mtouch_init() function > if the hw-calibrated coordinates were being used, so if someone changed the > value after a screen > was already connected, it would start reporting hw-calibrated coordinates > but the min/max values > would still be the raw min/max...however, for people wanting to change the > value and then hotplug > their touchscreens (to reset the min/max values), it would be useful. > Below is the patch with the > permissions adjusted. This kind of implies that you want this setting on a per-device basis, right? Why not make it attached to the individual device instead of a system-wide option? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
