Re: locking in hidraw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 4 Nov 2008, Jiri Slaby wrote:

> > in this code:
> > 
> > 		mutex_lock(&list->read_mutex);
> > 
> > 		if (list->head == list->tail) {
> > 			add_wait_queue(&list->hidraw->wait, &wait);
> > 			set_current_state(TASK_INTERRUPTIBLE);
> > 
> > it would make more sense to lock the mutex interruptable so all
> > tasks sleep the same way. Is this intentional?

Well, we have the test for pending signals just below that code, right?

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux