Re: cleanup of hiddev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum napsal(a):
> Am Dienstag, 4. November 2008 16:00:06 schrieb Alan Stern:
>> On Tue, 4 Nov 2008, Oliver Neukum wrote:
>>
>>> Am Montag, 3. November 2008 20:58:11 schrieb Jiri Slaby:
>>>> Hi.
>>>>
>>>>> this is the cleanup of hiddev against current vanilla. What do you think?
>>>> See my comments below.
>>> Hi,
>>>
>>> there still is a race of disconnect() with ioctl(). It seems like that
>>> code still operates under the assumption that both methods take
>>> BKL. Do you prefer a conservative fix with selective application of BKL
>>> or introduction of a new mutex?
>> It's none of my business... but IMO we should try to move away from the 
>> BKL as much as possible.
> 
> This is true but hiddev is in a sense legacy code which should be replaced
> with hidraw, so I tend to fix it conservatively.

Jiri K. is off for few days, I'm not responsible for the HID layer, he is, I
would let him to decide ;).
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux