Hi Paul, On Tue, Oct 28, 2008 at 07:18:57PM +0900, Paul Mundt wrote: > Ping. > > On Tue, Oct 21, 2008 at 05:38:16PM +0900, Paul Mundt wrote: > > This implements an optional polling mode for the gpio_keys driver, > > necessary for GPIOs that are not able to generate IRQs. > > > > Polling mode is done device granular, and can not be toggled for > > individual GPIOs in order to maintain simplicity. Platforms with both > > IRQ capable and incapable GPIOs are required to register multiple > > times, once for each case. > > > > > > - input_unregister_device(input); > > + if (pdata->polling) > > + input_unregister_polled_device(poll_dev); You also need to do input_free_polled_device (but not input_free_device - yeah, I know, its confusing... The reason is that input_dev is refcounted while input_polled_dev is not). > > + else > > + input_unregister_device(poll_dev->input); > > I also concerned with unconditionally polling INPUT_POLLDEV for all users of gpio-keys. Maybe we could make polling support optional? -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
